Conversation
Remove ka_lang reference. Clean up broken BCP 47 parsing and validation.
…d pycountry. Clean up language lookup json. Add several new languages.
rtibbles
force-pushed
the
sign_languages
branch
2 times, most recently
from
0114cf4 to
5ae75e1
Compare
Clean up zh language codes.
rtibbles
force-pushed
the
sign_languages
branch
from
5ae75e1 to
6a9784d
Compare
marcellamaki
approved these changes
Apr 16, 2025
Member
marcellamaki
left a comment
marcellamaki
left a comment
There was a problem hiding this comment.
Discussed with @rtibbles - overall approach makes sense, and only adds langauges (not remove, which could potentially go wrong).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zh-CNReferences
Needed for learningequality/kolibri-library#19
Reviewer guidance
Does the script make sense? Would it be better if the dependencies lived elsewhere rather than via dynamic installtion?
Noting that I did it this way, as the latest versions of these libraries do not support Python < 3.9