Clearing the search results not working when importing from channels

[radinamatic]

This is technically not a regression, as it's extant on production Studio and not just on hotfixes, but to me smells as blocker since it's one of the basic search functions. I've searched previous issues (open and closed), not even sure how we missed that previously 😕

Observed behavior

Clearing the search term from the field (either by using the 'Clear (X)' button or by deleting directly), does not update the search results.

clear-search.mp4

Expected behavior

Clearing the search term from the field should return the full list of channels (unfiltered by the previously deleted/cleared search term).

User-facing consequences

User confusion: since the URL remains the same, even if they delete the term and reload the page trying to clear, it will again return the results for the previous search. The only way to clear the search seems to be to 'Back to browse' which is not optimal, nor the expected pattern.

Steps to reproduce the issue

1. Open the channel to edit
2. Import from channels
3. Input the search term
4. Try to clear

Usage Details

• OS: all
• Browser: all

[vkWeb]

@radinamatic I think the behaviour that you are expecting here is exactly what's implemented on studio's public catalog search -- https://studio.learningequality.org/en/channels/#/public.

But on import search the current behaviour feels good UX to me.

Tho, I'm not 100% sure on what should be the right behaviour as I lack studio's UX design insights, I'll defer to @bjester @jtamiace to decide.

[radinamatic]

@vkWeb Yes, this one may need a bit more of thinking, I'll change the priority and add the 'needs decision' tag.
There is a discussion on Slack and more of my thoughts about what I see as problematic.

[nick2432]

Is this issue ready to contribute?

[MisRob]

Hi @nick2432, no, issue with "needs decisions" are not ready. I recommend searching for "help wanted".