Unstable - Follow-up to MVP modal for applying inheritable metadata

[pcenov]

Observed behavior

This is a follow-up to #4664 as the following scenarios are not working as specified which is noted in this comment as well:

• Move a resource into the second folder. You should be prompted to add the second folder's metadata

• Create a folder that has categories (etc_ tagged but no additional language. You should see the "Select details to add" text but not "update language" or any checkboxes

Additionally the option Don't ask me about this folder again is not working as the modal keeps popping up.

Expected behavior

Should be fully implemented as specified in #4664

Steps to reproduce the issue

1. Go to https://unstable.studio.learningequality.org/en/accounts/#/ and sign in
2. Create empty folders with different categories and create a folder that has only categories but no language
3. Start uploading resources and moving them in each of the folders

Additional information

no-modal.mp4

moving.to.folder.with.different.categories.but.no.language.mp4

dont-ask-not-working.mp4

Usage Details

• OS: Windows 10, Ubuntu
• Browser: Chrome, Firefox
• URL: https://unstable.studio.learningequality.org/
• Caused by: Bulk Edit Release #4635

[pcenov]

@radinamatic

[pcenov]

Hi @marcellamaki - also noticed that the modal pops up when I'm creating a new exercise:

exercise-modal.mp4

This is not described in #4664 so my guess is that it's a side effect and not the expected behavior?

[marcellamaki]

yes, this is not the expected behavior. thank you @pcenov! I'll address this within the scope of this issue.

[pcenov]

Thanks for confirming Marcella, after taking a closer look I can see that the modal is displayed even when I am simply creating a new folder within a folder, or restoring a deleted file so these scenarios should be fixed as well.

[rtibbles]

Flagging that the other behaviours described here are deliberate - every time a new item is added into a folder, the modal should appear unless the 'don't ask again' has been checked - we'll fix what is described in the body of the issue, but will leave the other existing behaviour as is.