disabled double submit while creating a channel#3843
disabled double submit while creating a channel#3843bjester merged 2 commits intolearningequality:unstablefrom AllanOXDi:disabled_double_submit_on_channel_creation
Conversation
| self.perform_create(serializer) | ||
|
|
||
| except IntegrityError as e: | ||
| return Response({"error": str(e)}, status=409) |
There was a problem hiding this comment.
I'm not sure it's worth doing, but if the endpoint returns this 409 status code, then perhaps the frontend can redirect to the channel page like it does with the normal 201 response?
There was a problem hiding this comment.
I think our main objective while implementing this was to try and throw a more meaningful error when creating a channel that the Id already exists.
There was a problem hiding this comment.
Okay! I was simply thinking about whether the change was as meaningful to the end-user as it is to us, since it would silence error reports on our end.
There was a problem hiding this comment.
I agree! But again, do we need a redirect when double creation happens? Or we could try and find a way of letting the user know if double creation happened.
There was a problem hiding this comment.
I think it's very unlikely a user encounters this scenario submitting the form. But if they somehow did encounter it, or perhaps even a gateway timeout 502 error, I don't think the frontend would give the user notice one of those errors occurred, meaning the submit button would be forever disabled without any indication to the user.
Summary
This PR fixes the double submit error while creating a new channel.
Ref #3833
Manual verification steps performed
Step 1: Try to create a new channel from studio, and observe what is happening on clicking create button.
Step 2: You may also try on a slow network connectivity
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)