Update Minio download link in local_dev_host.md and host_setup_services.md#4892
Conversation
GautamBytes
changed the title
GautamBytes
changed the title
|
HI @GautamBytes! Could you please add the issue that you are fixing in the PR description? You can add that under the "References" header with the keywords (Closes, Fixes or Resolves) preceding the issue number so it can auto close on merge |
|
Hey @akolson , actually i directly raised a pr instead of creating issue thinking it is documentation update. Added the issue no. under references, will keep this in mind from next time! |
docs/host_services_setup.md
Outdated
|
|
||
| # Install minio | ||
| wget https://dl.minio.io/server/minio/release/linux-amd64/archive/minio.RELEASE.2020-06-01T17-28-03Z -O bin/minio | ||
| wget https://dl.minio.io/server/minio/release/linux-amd64/minio -O ~/minio |
There was a problem hiding this comment.
I think ~/minio should be reverted back to bin/minio
docs/local_dev_host.md
Outdated
|
|
||
| # Install minio | ||
| wget https://dl.minio.io/server/minio/release/linux-amd64/archive/minio.RELEASE.2020-06-01T17-28-03Z -O bin/minio | ||
| wget https://dl.minio.io/server/minio/release/linux-amd64/minio -O ~/minio |
There was a problem hiding this comment.
akolson
left a comment
akolson
left a comment
There was a problem hiding this comment.
Hi @GautamBytes! Thanks for the changes! I left a few comments to look into. Thanks
|
Hey @akolson , did the required change , can you check now? |
There was a problem hiding this comment.
I not sure these changes were intended. Please check and revert the file to the original state. Thanks
There was a problem hiding this comment.
@akolson Yes, they were mistakenly pushed as i am using windows so webpack.config.js was changed a bit , removed those . Will you please check now?
There was a problem hiding this comment.
@GautamBytes, Unfortunately this deletes the file instead. please revert
|
Hey @akolson , sorry for the trouble😅 , pushed it back without the unwanted changes. Would you please have a look and confirm now if it is correct? |
There was a problem hiding this comment.
LGTM! Thanks for your persistence on resolving the issue @GautamBytes
3 participants
Summary
References
Fixes #4898
NA
Reviewer guidance
No UI changes; only documentation updates.