Imported StudioOfflineAlert in ChannelListIndex#5374
Merged
MisRob merged 2 commits intolearningequality:unstablefrom Sep 10, 2025
Merged
Imported StudioOfflineAlert in ChannelListIndex#5374MisRob merged 2 commits intolearningequality:unstablefrom
MisRob merged 2 commits intolearningequality:unstablefrom
Conversation
MisRob
reviewed
Sep 10, 2025
Member
MisRob
left a comment
MisRob
left a comment
There was a problem hiding this comment.
Thanks @Virajjai, code looks good and I confirm it works well. Just one cleanup note, then we can merge.
I wanted to mention that I will be on vacation until September 22, so unless someone else merges your PR after you've resolved the feedback, I will get back to you as soon as I'm back.
contentcuration/contentcuration/frontend/channelList/views/ChannelListIndex.vue
Outdated
Show resolved
Hide resolved
MisRob
approved these changes
Sep 10, 2025
Member
|
Thank you and congratulations on your first contribution in Studio @Virajjai |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Imported StudioOfflineAlert changing the OfflineText in ChannelListIndex, and updated the file with the change in import.
I have checked there is no change in UI.
References
Closes #5219
Reviewer guidance
There are only changes in ChannelListIndex.vue file.