[Remove Vuetify from Studio] Collection name input and validation in Channels - New collection#5382
Conversation
|
I'll look into the failing workflow 👍 |
|
Hi @AadarshM07, thank you! Yes please have a look at failing tests. We will assign a reviewer soon. |
4093579 to
23458e0
Compare
|
I updated the tests to replace |
marcellamaki
left a comment
There was a problem hiding this comment.
Hi @AadarshM07 - thanks for your work on this! Overall, the test changes and general code implementation looks fine, and it seems to be working without regressions. One small request - can you remove the snackbar error handling that you added? I can understand the idea, but it doesn't seem to be in the requirements for the original issue, and I think the error message of fixing the error "below" is a bit odd.
After that, I think this will be ready to be approved and merged!
|
@marcellamaki sure i will update this at the earliest👍 |
|
@marcellamaki I have updated this, Hope it helps! |
marcellamaki
left a comment
There was a problem hiding this comment.
Thank you @AadarshM07! This is approved. We appreciate your contribution :)
Summary
Removed Vuetify from the collection name input on the
Channels > New Collection page, and updated the validation logic togenerateFormMixin.Verified that the text box still supports the following features:
Screenshots:
…
References
Closes #5298
…
Reviewer guidance
In the previous Vuetify textbox behavior, the "Field is required" message appeared when submitting without input and disappeared once the textbox was focused again.
In the current
KTextbox, the error message does not disappear on focus after being triggered.I checked the KTextbox documentation and couldn’t find any prop that controls this behavior - if this is not the right approach, suggestions would be helpful.
…