Skip to content

[Remove Vuetify from Studio] Remove temporary ::v-deep override from external links on licenses modal#5507

Merged
MisRob merged 1 commit intolearningequality:unstablefrom
vtushar06:fix/remove-kexternal-link-deep-override
Oct 31, 2025
Merged

[Remove Vuetify from Studio] Remove temporary ::v-deep override from external links on licenses modal#5507
MisRob merged 1 commit intolearningequality:unstablefrom
vtushar06:fix/remove-kexternal-link-deep-override

Conversation

@vtushar06
Copy link
Contributor

Summary

Removes temporary ::v-deep CSS override for .license-link that was added in PR #5107 to fix KExternalLink's incorrect margin.

This override is no longer needed since the root cause has been fixed in KDS PR #1125 (merged) and Studio now has the latest KDS version.

Changes:

  • Removed ::v-deep span { margin-left: 0 !important; } override from RequestForm.vue

Verification:

  • Checked "Learn More" links in Settings > Storage > Request More Space form display correctly with proper spacing

References

Reviewer guidance

  1. Navigate to Settings > Storage > Request More Space
  2. Expand the "About Licenses" section
  3. Verify "Learn More" links have correct spacing and alignment
  4. Test in both LTR and RTL languages if possible

@MisRob MisRob self-assigned this Oct 27, 2025
@MisRob MisRob self-requested a review October 27, 2025 05:40
@MisRob MisRob changed the title Remove unnecessary CSS rule for license link margin in RequestForm.vue [Remove Vuetify from Studio] Remove temporary ::v-deep override from external links on licenses modal Oct 28, 2025
Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtushar06 - all good.

I need to check with the team on the failing check before we merge. I don't think it's related to your changes.

@MisRob MisRob merged commit 70cb8da into learningequality:unstable Oct 31, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Remove Vuetify from Studio] Remove temporary ::v-deep override from external links on licenses modal

2 participants