Fix TitleBarButton Foreground error when change theme#1005
Merged
pomianowski merged 1 commit intolepoco:developmentfrom Mar 18, 2024
Merged
Fix TitleBarButton Foreground error when change theme#1005pomianowski merged 1 commit intolepoco:developmentfrom
pomianowski merged 1 commit intolepoco:developmentfrom
Conversation
pomianowski
approved these changes
Mar 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
While changing theme between light and dark, the TitleBarButton Foreground not following the updated theme.
Issue Number: #993 (comment) reported by @koal44
What is the new behavior?
RenderButtonsForegroundas canvas fill colorButtonsForegroundchange, to make change after theme color changed.Other information