Fix regression in PR #1012#1015
Merged
pomianowski merged 2 commits intolepoco:developmentfrom Mar 25, 2024
Merged
Conversation
As @koal44 pointed out, lepoco#1012 introduced a bug which made the app crash when using FluentLeft navigation because updating the visual state tries to animate a width to or from OpenPaneLength=NaN. To avoid this, don't try to change the visual state for navigation view modes that don't have an open and a compact state.
github-actions
bot
added
controls
7 tasks
pomianowski
approved these changes
Mar 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @koal44 pointed out, #1012 introduced a bug which made the app crash when using FluentLeft navigation because updating the visual state tries to animate a width to or from OpenPaneLength=NaN. Sorry about that.
To avoid this, don't try to change the visual state for navigation view modes that don't have an open and a compact state.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
App crashes when using FluentLeft navigation mode, or at least it did before dd83b6e
Issue Number: Comment in PR #1012
What is the new behavior?
Don't try to change the visual state for FluentLeft, Top or Bottom navigation view modes
Other information