Fixed menu item add when item added to the ObservableCollection#1092
Closed
crippledfaith wants to merge 3 commits intolepoco:developmentfrom
Closed
Conversation
…ned to MenuItemsSource
added 2 commits
May 19, 2024 01:25
…to FooterMenuItemsPropertyKey
Merged
7 tasks
pomianowski
requested changes
Jun 2, 2024
| /// Gets or sets the object that represents the navigation items to be used in the footer menu. | ||
| /// </summary> | ||
| object? FooterMenuItemsSource { get; set; } | ||
| ObservableCollection<object> FooterMenuItemsSource { get; set; } |
Member
There was a problem hiding this comment.
ItemSource of other WPF controlls does not directly bound to ObservableCollection
https://learn.microsoft.com/pl-pl/dotnet/api/system.windows.controls.itemscontrol.itemssource?view=windowsdesktop-8.0#system-windows-controls-itemscontrol-itemssource
Author
Member
There was a problem hiding this comment.
This is a recommendation to the end user, which does not mean that the library should enforce this type of collection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
When MenuItemsSource or FooterMenuItemsSource in MVVM binding to ObservableCollection the Item added to the collection dose not update in the UI.
Issue Number: N/A
What is the new behavior?
NavigationView item will add the Item
Other information