Skip to content

fix: PlaceholderText may not display promptly under certain circumstances#1115

Merged
pomianowski merged 1 commit intolepoco:developmentfrom
textGamex:fix-placeholder
Jun 8, 2024
Merged

fix: PlaceholderText may not display promptly under certain circumstances#1115
pomianowski merged 1 commit intolepoco:developmentfrom
textGamex:fix-placeholder

Conversation

@textGamex
Copy link
Copy Markdown
Contributor

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

When we set PlaceholderEnabled from false to true, if the Text is empty, the PlaceholderText will not display immediately; it will only appear after the OnTextChanged method is triggered.

Issue Number: N/A

What is the new behavior?

  • A new callback function, OnPlaceholderEnabledChanged, has been added. When PlaceholderEnabled is set from false to true, if the Text is empty, the PlaceholderText will be displayed immediately, and vice versa.

Other information

@textGamex textGamex requested a review from pomianowski as a code owner June 7, 2024 18:14
@github-actions github-actions bot added controls Changes to the appearance or logic of custom controls. PR Pull request dotnet labels Jun 7, 2024
@textGamex textGamex marked this pull request as draft June 7, 2024 18:14
@textGamex textGamex marked this pull request as ready for review June 7, 2024 18:16
@pomianowski pomianowski merged commit 150e05d into lepoco:development Jun 8, 2024
@textGamex textGamex deleted the fix-placeholder branch June 9, 2024 00:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

controls Changes to the appearance or logic of custom controls. dotnet PR Pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants