Skip to content

Fix: Possible multiple invocations of the INavigationAware interface methods #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pomianowski merged 2 commits into from
Jun 10, 2024
Merged

Fix: Possible multiple invocations of the INavigationAware interface methods #1116

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9c1da1
fix: possible multiple invocations of the INavigationAware interface …
textGamex Jun 10, 2024
8657868
Merge branch 'development' into fix-bug
pomianowski Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 22 additions & 30 deletions src/Wpf.Ui/Controls/NavigationView/NavigationViewContentPresenter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,47 +183,39 @@ private void ApplyTransitionEffectToNavigatedPage(object content)

private static void NotifyContentAboutNavigatingTo(object content)
{
if (content is INavigationAware navigationAwareNavigationContent)
switch (content)
{
navigationAwareNavigationContent.OnNavigatedTo();
}

if (
content is INavigableView<object>
case INavigationAware navigationAwareNavigationContent:
navigationAwareNavigationContent.OnNavigatedTo();
break;
case INavigableView<object>
{
ViewModel: INavigationAware navigationAwareNavigableViewViewModel
}
)
{
navigationAwareNavigableViewViewModel.OnNavigatedTo();
}

if (content is FrameworkElement { DataContext: INavigationAware navigationAwareCurrentContent })
{
navigationAwareCurrentContent.OnNavigatedTo();
}:
navigationAwareNavigableViewViewModel.OnNavigatedTo();
break;
case FrameworkElement { DataContext: INavigationAware navigationAwareCurrentContent }:
navigationAwareCurrentContent.OnNavigatedTo();
break;
}
}

private static void NotifyContentAboutNavigatingFrom(object content)
{
if (content is INavigationAware navigationAwareNavigationContent)
switch (content)
{
navigationAwareNavigationContent.OnNavigatedFrom();
}

if (
content is INavigableView<object>
case INavigationAware navigationAwareNavigationContent:
navigationAwareNavigationContent.OnNavigatedFrom();
break;
case INavigableView<object>
{
ViewModel: INavigationAware navigationAwareNavigableViewViewModel
}
)
{
navigationAwareNavigableViewViewModel.OnNavigatedFrom();
}

if (content is FrameworkElement { DataContext: INavigationAware navigationAwareCurrentContent })
{
navigationAwareCurrentContent.OnNavigatedFrom();
}:
navigationAwareNavigableViewViewModel.OnNavigatedFrom();
break;
case FrameworkElement { DataContext: INavigationAware navigationAwareCurrentContent }:
navigationAwareCurrentContent.OnNavigatedFrom();
break;
}
}
}