Workaround for touch input triggering alongside the hwnd hook on titlebar#1153
Merged
pomianowski merged 2 commits intolepoco:developmentfrom Jul 24, 2024
Difegue:touch-maximize-workaround
Merged
Workaround for touch input triggering alongside the hwnd hook on titlebar#1153pomianowski merged 2 commits intolepoco:developmentfrom Difegue:touch-maximize-workaround
pomianowski merged 2 commits intolepoco:developmentfrom
Difegue:touch-maximize-workaround
Conversation
Fixes #1126 Setting hittest to false disables touch input on the button, which was firing alongside WM_NCLBUTTONUP in the hwndhook, resulting in the command being fired twice.
github-actions
bot
added
controls
pomianowski
approved these changes
Jul 24, 2024
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Using touch on the maximize button fires the matching command twice, resulting in the window quickly maximizing and restoring itself
Issue Number: #1126
What is the new behavior?
Setting hittest to false disables touch input on the button, which was firing alongside WM_NCLBUTTONUP in the hwndhook, resulting in the command being fired twice.
Other information
It might be better to just catch WM_TOUCH alongside the other events in the hook to prevent this, but I wasn't able to make that work unfortunately 🤔