Merged
Conversation
github-actions
bot
added
controls
pomianowski
approved these changes
Feb 1, 2025
pomianowski
pushed a commit
that referenced
this pull request
Feb 1, 2025
* Fix TextControl placeholders not using the proper color * Fix InfoBar padding so it's centered for single-line messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
The placeholder text brush for TextControls is incorrect.
We've also seen that when using a single-line InfoBar, the text isn't centered vertically within the control. (This is also the case for multi-line InfoBars, but it's less jarring..)
Issue Number: N/A
What is the new behavior?
Other information