Disable NavigationViewContentPresenter refreshing from keyboard#1298
Merged
pomianowski merged 1 commit intolepoco:mainfrom Dec 25, 2024
Merged
Disable NavigationViewContentPresenter refreshing from keyboard#1298pomianowski merged 1 commit intolepoco:mainfrom
pomianowski merged 1 commit intolepoco:mainfrom
Conversation
github-actions
bot
added
controls
pomianowski
approved these changes
Dec 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now NavigationViewContentPresenter inherits keyboard navigation from Frame.
I suggest that NavigationViewContentPresenter should not be updated when pressing
F5. This triggers the Navigating event and INavigationAware notifications. It also reloads the page itself.This behaviour of Frame is fine when it is displaying Web content, but we use it to navigate the Desktop application.
Pull request type
Please check the type of change your PR introduces: