Invoke INavigationAware callbacks on UI thread#1307
Merged
pomianowski merged 1 commit intolepoco:mainfrom Feb 1, 2025
Merged
Conversation
e84591f to
3363419
Compare
3363419 to
b56303d
Compare
b56303d to
bf18c3e
Compare
pomianowski
approved these changes
Feb 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
INavigationAwarecallbacks are invoked on the thread pool, and exceptions are silently discarded.Issue Number: #1306
What is the new behavior?
AppDomain.CurrentDomain.UnhandledExceptionevent.Other Information
I have also removed the now-unnecessary UI dispatching code from the demo and gallery base view models.