fix(ListView): use themed disabled background instead of SystemColors.ControlBrush#1554
Merged
pomianowski merged 1 commit intolepoco:mainfrom Oct 28, 2025
Merged
Conversation
Contributor
Author
|
I will close this PR due to a type conversion error. |
Contributor
Author
|
Reopening this PR as the issue was unrelated. After further investigation, I've confirmed that the exception in my project was caused by an unrelated issue. This PR, which applies the themed disabled background, is correct and does not introduce any regressions. The fix here is still valid and improves theme consistency. It is ready for review. |
pomianowski
approved these changes
Oct 28, 2025
This was referenced Nov 24, 2025
This was referenced Dec 2, 2025
This was referenced Dec 22, 2025
This was referenced Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Problem The ListView with GridView template (GridViewTemplate) sets the disabled state background to SystemColors.ControlBrush, bypassing Wpf.Ui’s theme resource keys. In dark themes this produces a jarring white block while adjacent controls use dark palette values, breaking visual consistency.
Screenshot (Dark Theme):

Screenshot (Light Theme):

Changes made:
Updated the disabled state background in ListView's GridViewTemplate from
SystemColors.ControlBrushKeytoControlFillColorDisabledBrush.What is the new behavior?
Effects Disabled ListView with GridView now blends into the themed surface (light: subtle muted fill; dark: appropriate subdued dark tone) instead of defaulting to pure white.
Screenshot (Dark Theme):

Screenshot (Light Theme):

Other information
I believe a better approach would be to remove this trigger and not alter the background color for the disabled state at all. However, for now, this fix is scoped only to replacing the brush.