Skip to content

fix(controls): Fix ProgressRing not restarting properly when visibily changes #1678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nuklon wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(controls): Fix ProgressRing not restarting properly when visibily changes #1678

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7f58ef
Fix ProgressRing not restarting properly when visibily changes
Nuklon Mar 24, 2026
ba983b7
Use resume/pause/seek instead
Nuklon Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 32 additions & 23 deletions src/Wpf.Ui/Controls/ProgressRing/ProgressRing.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!--
<!--
This Source Code Form is subject to the terms of the MIT License.
If a copy of the MIT was not distributed with this file, You can obtain one at https://opensource.org/licenses/MIT.
Copyright (C) Leszek Pomianowski and WPF UI Contributors.
Expand Down Expand Up @@ -65,32 +65,41 @@
</controls:Arc>
</Grid>
<ControlTemplate.Triggers>
<EventTrigger SourceName="Arc" RoutedEvent="Loaded">
<BeginStoryboard Name="RotateStoryboard">
<Storyboard>
<DoubleAnimation
RepeatBehavior="Forever"
Storyboard.TargetName="Arc"
Storyboard.TargetProperty="(Canvas.RenderTransform).(RotateTransform.Angle)"
To="360"
Duration="0:0:2" />
<DoubleAnimation
AutoReverse="True"
RepeatBehavior="Forever"
Storyboard.TargetName="Arc"
Storyboard.TargetProperty="EndAngle"
From="100"
To="320"
Duration="0:0:5" />
</Storyboard>
</BeginStoryboard>
</EventTrigger>
<Trigger Property="IsEnabled" Value="True">
<Trigger.EnterActions>
<BeginStoryboard>
<Storyboard>
<DoubleAnimation
RepeatBehavior="Forever"
Storyboard.TargetName="Arc"
Storyboard.TargetProperty="(Canvas.RenderTransform).(RotateTransform.Angle)"
To="360"
Duration="0:0:2" />

<DoubleAnimation
AutoReverse="True"
RepeatBehavior="Forever"
Storyboard.TargetName="Arc"
Storyboard.TargetProperty="EndAngle"
From="100"
To="320"
Duration="0:0:5" />
</Storyboard>
</BeginStoryboard>
<ResumeStoryboard BeginStoryboardName="RotateStoryboard" />
</Trigger.EnterActions>
<Trigger.ExitActions>
<PauseStoryboard BeginStoryboardName="RotateStoryboard" />
</Trigger.ExitActions>
</Trigger>
<Trigger Property="IsVisible" Value="True">
<Trigger.EnterActions>
<ResumeStoryboard BeginStoryboardName="RotateStoryboard" />
</Trigger.EnterActions>
<Trigger.ExitActions>
<BeginStoryboard>
<Storyboard />
</BeginStoryboard>
<PauseStoryboard BeginStoryboardName="RotateStoryboard" />
<SeekStoryboard BeginStoryboardName="RotateStoryboard" Offset="0" />
</Trigger.ExitActions>
</Trigger>
</ControlTemplate.Triggers>
Expand Down
Loading