Skip to content

Fixed NavigationStore style#25

Closed
MajorXAML wants to merge 2 commits intolepoco:mainfrom
MajorXAML:main
Closed

Fixed NavigationStore style#25
MajorXAML wants to merge 2 commits intolepoco:mainfrom
MajorXAML:main

Conversation

@MajorXAML
Copy link
Copy Markdown
Contributor

To match the Microsoft Store window

To match the Windows Store window
@pomianowski
Copy link
Copy Markdown
Member

I think that ActiveBorder and ElementIcon should have SystemAccentBrush.

image

@MajorXAML
Copy link
Copy Markdown
Contributor Author

MajorXAML commented Jan 11, 2022

I think that ActiveBorder and ElementIcon should have SystemAccentBrush.

As far as I understand, the pure system brush is almost never used in the interface. Except for the AccentFillColorSelectedTextBackgroundBrush

Microsoft creates three shades from SystemAccentColor for each theme and uses them. So ActiveBorder and ElementIcon must use AccentFillColorDefaultBrush like a button for example. I did a little comparison of the two colors in windows toolkit, please take a look.
colors

I've highlighted the same colors with a border, and as you can see, their order for AccentText is different for the two themes. That's why I suggested splitting the brushes into two theme files.

Dark theme
<SolidColorBrush x:Key="AccentTextFillColorPrimaryBrush" Color="{ThemeResource SystemAccentColorLight3}" />
<SolidColorBrush x:Key="AccentTextFillColorSecondaryBrush" Color="{ThemeResource SystemAccentColorLight3}" />
<SolidColorBrush x:Key="AccentTextFillColorTertiaryBrush" Color="{ThemeResource SystemAccentColorLight2}" />

Light theme
<SolidColorBrush x:Key="AccentTextFillColorPrimaryBrush" Color="{ThemeResource SystemAccentColorDark2}" />
<SolidColorBrush x:Key="AccentTextFillColorSecondaryBrush" Color="{ThemeResource SystemAccentColorDark3}" />
<SolidColorBrush x:Key="AccentTextFillColorTertiaryBrush" Color="{ThemeResource SystemAccentColorDark1}" />

Yes, Dark theme uses SystemAccentColorLight and Dark uses SystemAccentColorLight 🤯🤯🤯
according to the Common_themeresources_any.xaml file... But it doesn't seem right to me.

Fun fact SystemAccentColorLight1 is never used... it's not even there.

@MajorXAML MajorXAML closed this Feb 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants