Skip to content

Fixed app published as singleFile not running (issue #483)#506

Merged
pomianowski merged 1 commit intolepoco:developmentfrom
Aybex:development
Jan 23, 2023
Merged

Fixed app published as singleFile not running (issue #483)#506
pomianowski merged 1 commit intolepoco:developmentfrom
Aybex:development

Conversation

@Aybex
Copy link
Copy Markdown
Contributor

@Aybex Aybex commented Jan 20, 2023

Currently executables published as singleFile are not running. (See Issue #483)
The problem is in setting the Host object's Base Path as "Assembly.GetEntryAssembly()!.Location" returns null.
Based @MrCosmo suggestion changing it to "AppContext.BaseDirectory" works perfectly.

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

  • Executables published as singleFile are not running.

Issue Number: #483

What is the new behavior?

  • Executables published as singleFile run fine.

@Aybex Aybex requested a review from pomianowski as a code owner January 20, 2023 00:22
@pomianowski pomianowski merged commit 7021685 into lepoco:development Jan 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants