Controls update

[IvanDmitriev1]

Deleted Dialog control.
Changed .editorconfig so that it is the same as in the dotnet/runtime repository.
Added folders for TitleBar, MessageBox, ContentDialog, VirtualizingWrapPanel, NumberBox controls.
Added small fixes.

Pull request type

• Update
• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes

[pomianowski]

Hey, thanks for organizing the cleanup.

For the namespace to work properly, Properties\AssemblyInfo.cs needs to be updated. Same for VisualStudioToolsManifest.xml.

As for IDialogService, I find it useful and think that it should be rewritten for DialogControl.

[IvanDmitriev1]

Ok.

[IvanDmitriev1]

For the namespace to work properly, Properties\AssemblyInfo.cs needs to be updated. Same for VisualStudioToolsManifest.xml.

Actually I didn't change namespace, they all have the Wpf.Ui.Controls namespace.

[pomianowski]

For the namespace to work properly, Properties\AssemblyInfo.cs needs to be updated. Same for VisualStudioToolsManifest.xml.

Actually I didn't change namespace, they all have the Wpf.Ui.Controls namespace.

I'm not a fan of the solution when the namespace is not the same as the directory tree.

[IvanDmitriev1]

At the same time, all controls should have the namespace Wpf.Ui.Controls, isn't that right?

[pomianowski]

At the same time, all controls should have the namespace Wpf.Ui.Controls, isn't that right?

No need, namespace is added to AssemblyInfo.

wpfui/src/Wpf.Ui/Controls/Navigation/NavigationView.Parent.cs

Line 11 in 87f203c

namespace Wpf.Ui.Controls.Navigation;

wpfui/src/Wpf.Ui/Properties/AssemblyInfo.cs

Line 20 in 87f203c

[assembly: XmlnsDefinition("http://schemas.lepo.co/wpfui/2022/xaml", "Wpf.Ui.Controls.Navigation")]

[IvanDmitriev1]

No need, namespace is added to AssemblyInfo.

But it for XAML not for c#.

[pomianowski]

No need, namespace is added to AssemblyInfo.

But it for XAML not for c#.

It doesn't matter what the namespace is, it could even be Wpf.Ui.Xyz and everything should still work.

Unless you mean a naming convention to keep everything neatly in one place.
Well, so far I've decided that we should stick to the directory tree, but if everything in Controls is more convenient and in line with what is in the main WPF, we can consider it that way.

[IvanDmitriev1]

Unless you mean a naming convention to keep everything neatly in one place. Well, so far I've decided that we should stick to the directory tree, but if everything in Controls is more convenient and in line with what is in the main WPF, we can consider it that way.

Yep

[pomianowski]

Unless you mean a naming convention to keep everything neatly in one place. Well, so far I've decided that we should stick to the directory tree, but if everything in Controls is more convenient and in line with what is in the main WPF, we can consider it that way.

Yep

Well, then, just like the main WPF, we can omit decorative subfolders and keep everything in one place, taking care of the correctness of the namespace.
https://github.com/dotnet/wpf/tree/main/src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Controls

[IvanDmitriev1]

Then I prefer the directory tree.

[IvanDmitriev1]

But at the same time winui 3.
https://github.com/microsoft/microsoft-ui-xaml/tree/main/dev

[pomianowski]

But at the same time winui 3. https://github.com/microsoft/microsoft-ui-xaml/tree/main/dev

Well yes, but it's a CPP project

[IvanDmitriev1]

In my opinion , c++ namespace structured by folders, at least I did. Although c++ has no standard on this.