[NavSvc] make INavigationService.Navigate*() accepts dataContext as argument#944
Merged
pomianowski merged 2 commits intolepoco:developmentfrom Mar 13, 2024
Merged
Conversation
add these 3 overload methods with `dataContext` to `INavigationService` so that
```C#
bool Navigate(Type pageType, object dataContext);
bool Navigate(string pageIdOrTargetTag, object dataContext);
bool NavigateWithHierarchy(Type pageType, object dataContext);
```
However, if the current displaying page (ie. top-most navigation stack) is `pageType`, `Navigate*(...)` returns `false` and does nothing.
I managed to force-refresh the stack by doing this in client code:
```C#
while (!NavSvc.NavigateWithHierarchy(typeof(SomePage), someData)
{
// failed, try pop the stack and try again
if (!NavSvc.GoBack())
{
// cannot pop stack, really failed...
Log.LogCritical(...);
break;
}
}
```
INavigationService.Navigate*() accepts dataContext as argument
pomianowski
approved these changes
Mar 13, 2024
Member
|
Hey @Palatis, thanks for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
INavigationServicelacks a way to specifydataContextfor navigating.Yes, we can get the underlying
NavigationControland navigate withdataContextobject like this:but... that's a bit tedious.
Issue Number: N/A
What is the new behavior?
add these 3 overload methods with
dataContexttoINavigationServiceso client code can just do
NavigationService.Navigate(type, data)without the hassle.Other information
However, if the current displaying page (ie. top-most navigation stack) is
pageType,Navigate*(...)returnsfalseand does nothing.I managed to force-refresh the stack by doing this in client code: