Eliminate un-selectable space between ComboBoxItems#978
Merged
pomianowski merged 3 commits intolepoco:developmentfrom Mar 13, 2024
tmijail:ComboBoxWhitespace
Merged
Eliminate un-selectable space between ComboBoxItems#978pomianowski merged 3 commits intolepoco:developmentfrom tmijail:ComboBoxWhitespace
pomianowski merged 3 commits intolepoco:developmentfrom
tmijail:ComboBoxWhitespace
Conversation
…een ComboBoxItems Currently, `ComboBoxItem` and `Border` both have margins equal to `ComboBoxItemMargin`. This gives an effective margin of `2 * ComboBoxItemMargin`. By removing the `ComboBoxItem` margin and setting `Border`'s margin to `2 * ComboBoxItemMargin` we ensure there's no space between `ComboBoxItem`s that can't be clicked to change the selection. A downside of this is that the customizability of `ComboBoxItem` is diminished. It is possible to increase the margin but not decrease it under `2 * ComboBoxItemMargin`
pomianowski
approved these changes
Mar 11, 2024
Member
|
Hey @tmijail, thanks for your contribution ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminates blank space that can't be clicked to change the selection of a ComboBox and that doesn't respond when you mouse over it.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
There's a space between the end of the highlighted
ComboBoxItem'sBorderand the start of the nextComboBoxItem'sContentPresenterthat doesn't respond to mouse over and that doesn't affect theComboBox's value when clicked.ComboBox.Before.mp4
Issue Number: N/A
What is the new behavior?
After the first commit, the un-selectable space is decreased significantly:
ComboBox.First.Commit.mp4
The second commit eliminates the un-selectable space completely:
ComboBox.Second.Commit.mp4
The downside of this second commit is that it diminishes the customizability of ComboBoxItem. It is possible to increase the effective margin but not decrease it bellow
6,4,6,0(see the commit description).Other information