Skip to content

feat(rule): support temp rule#3818

Merged
ngjaying merged 1 commit intomasterfrom
temp
Aug 8, 2025
Merged

feat(rule): support temp rule#3818
ngjaying merged 1 commit intomasterfrom
temp

Conversation

@ngjaying
Copy link
Collaborator

@ngjaying ngjaying commented Aug 8, 2025

  1. Can be listed in get all rules
  2. Can get status
  3. Return error for get rule, because the rule is not saved
  4. No version support

1. Can be listed in get all rules
2. Can get status
3. Return error for get rule, because the rule is not saved
4. No version support

Signed-off-by: huangjy <huangjy@emqx.io>
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@codecov
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 71.05263% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.04%. Comparing base (9f93e61) to head (2d17c19).
⚠️ Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
internal/processor/rule.go 50.00% 10 Missing and 4 partials ⚠️
internal/server/rule_init.go 20.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3818      +/-   ##
==========================================
- Coverage   71.05%   71.04%   -0.01%     
==========================================
  Files         439      439              
  Lines       50634    50671      +37     
==========================================
+ Hits        35976    35999      +23     
- Misses      11825    11843      +18     
+ Partials     2833     2829       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ngjaying ngjaying marked this pull request as ready for review August 8, 2025 05:59
@ngjaying ngjaying requested a review from Yisaer August 8, 2025 05:59
@ngjaying ngjaying merged commit 65f43e6 into master Aug 8, 2025
67 checks passed
@ngjaying ngjaying deleted the temp branch August 8, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants