Skip to content

Conversation

@rucoder
Copy link
Collaborator

@rucoder rucoder commented Dec 15, 2025

pull_request_target workflow is taken from a default branch however it must not be run for

  • eve-kernel-arm64-v5.15.136-nvidia-jp6
  • eve-kernel-arm64-v5.10.192-nvidia-jp5
  • So disable it for these branches

pull_request_target workflow is taken from a default branch however it must not be run for
eve-kernel-arm64-v5.15.136-nvidia-jp6 and eve-kernel-arm64-v5.10.192-nvidia-jp5. So disable
it for these brtanches

Signed-off-by: Mikhail Malyshev <[email protected]>
@rucoder rucoder requested review from Copilot and rene December 15, 2025 15:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +8 to +9
- "!eve-kernel-arm64-v5.15.136-nvidia-jp6"
- "!eve-kernel-arm64-v5.10.192-nvidia-jp5"
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The negation pattern syntax used here will not work as intended in GitHub Actions. When using branches filter in pull_request_target, you cannot use negation patterns (with ! prefix) to exclude specific branches from a wildcard pattern.

The correct approach is to use branches-ignore alongside branches, or to specify explicit branch patterns. Consider one of these alternatives:

  1. Use a combination of branches and branches-ignore (note they cannot be used together, so you'd need to rethink the filter strategy)
  2. List all desired branches explicitly without wildcards
  3. Use an if condition in the job level to check and skip the JP branches

For example, you could add a condition at the job level:

jobs:
  build:
    if: |
      !startsWith(github.event.pull_request.base.ref, 'eve-kernel-arm64-v5.15.136-nvidia-jp6') &&
      !startsWith(github.event.pull_request.base.ref, 'eve-kernel-arm64-v5.10.192-nvidia-jp5')

Copilot uses AI. Check for mistakes.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rene oh, GHA are SO limited... I have no good words...

@rucoder rucoder marked this pull request as draft December 15, 2025 16:43
pull_request_target:
branches:
- "gha-test-rebase"
- "eve-kernel-*"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rucoder , what about if we just set here eve-kernel-amd64-* instead of eve-kernel-* ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants