fix: use UUID for podcast episode directory names#666
Merged
Conversation
Podcast episode names with spaces or special characters caused filesystem errors when used directly as directory names. Use UUID-based directory names instead, keeping the original episode name in the database for display purposes. Closes #663
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Confidence score: 3/5
- There is a meaningful regression-risk gap in
tests/test_podcast_path.py: the test reimplements path generation logic instead of calling the real podcast path builder, so failures in production logic may be missed. - Given the medium severity (6/10) and high confidence (9/10), this is more than a housekeeping issue—it weakens trust in test coverage for path handling behavior.
- This PR may still be mergeable, but it carries some risk until the test is aligned to exercise the actual implementation and uses
problematic_namesas intended. - Pay close attention to
tests/test_podcast_path.py- test logic may mask real path-builder breakages.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="tests/test_podcast_path.py">
<violation number="1" location="tests/test_podcast_path.py:13">
P2: This test file reimplements path generation instead of invoking the actual podcast path builder, so it can pass even when production code is broken. In particular, `problematic_names` are never used to drive the generated path.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Tests were reimplementing UUID logic locally instead of testing the actual production code path. Extract the path-building logic into a testable helper function and import it directly in tests.
devkavach22
pushed a commit
to kavachglobaladmin/kavach-open-notebook
that referenced
this pull request
Apr 15, 2026
fix: use UUID for podcast episode directory names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
My Episode: Part 1) were used directly as directory names, causing filesystem errors on Linux/DockerCloses #663
Test plan
tests/test_podcast_path.pycovering UUID format, path validity, no collisions, no unsafe characters, POSIX compatibility, and real filesystem creation