Fix uninstantiated bYRotation variable & Lint#18
Closed
shaneboyar wants to merge 2 commits intolhandel:masterfrom
shaneboyar:master
Closed
Fix uninstantiated bYRotation variable & Lint#18shaneboyar wants to merge 2 commits intolhandel:masterfrom shaneboyar:master
shaneboyar wants to merge 2 commits intolhandel:masterfrom
shaneboyar:master
Conversation
ichko
approved these changes
Nov 12, 2019
| sideBTransform.transform.push({ rotateX: bXRotation }); | ||
| } else { | ||
| if (Platform.OS === "ios") { | ||
| let bYRotation; |
There was a problem hiding this comment.
Maybe this can be done with ternary operator?
Author
There was a problem hiding this comment.
Definitely. There's probably some other refactoring that can be done as well, but I was just hoping to get this bug quickly fixed in this PR.
Author
|
@lhandel Can we get this merged in? |
ckknight
pushed a commit
to ckknight/react-native-card-flip
that referenced
this pull request
Jan 21, 2020
Although it's likely that lhandel#18 probably also fixes this, I attempted to take a much lighter touch and just fix the problem at hand.
|
@lhandel merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the
bYRotationvariable which is conditionally set in thegetCardBTransformationmethod is not instantiated and therefore cannot be redefined.I also ran a linter on it, so let me know if you want me to revert those changes.