Load all certs in a CaBuffer #1224
Merged
+62
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@COM8 Changes modified accordingly |
COM8
requested changes
May 29, 2025
cpr/ssl_ctx.cpp
Outdated
| // Create a memory BIO using the data of cert_buf | ||
| // Note: It is assumed, that cert_buf is nul terminated and its length is determined by strlen | ||
| char* cert_buf = static_cast<char*>(raw_cert_buf); | ||
| bio_ptr bio = BIO_new_mem_buf(cert_buf, -1); |
Member
There was a problem hiding this comment.
Suggested change
| bio_ptr bio = BIO_new_mem_buf(cert_buf, -1); | |
| BIO * bio = BIO_new_mem_buf(cert_buf, -1); |
I guess here I suggested the wrong type. The CI fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Thanks for the great project.
I noticed that
cpr::CaBufferdoesn't load all certificates in the buffer: just the first one.PEM_read_bio_X509is meant to run in a loop (some examples) to add all certs in the buffer. This PR covers this.It also fixes the inclusion of
openssl/pemerr.hin BoringSSL, which doesn't exist. This closes #333 (comment)There's also an unused error printer that I removed, which caused issues with
-WerrorCheers!