This repository was archived by the owner on May 14, 2020. It is now read-only.
Simplify creating HTTP errors#194
Merged
thewilkybarkid merged 2 commits intolibero:masterfrom Jan 21, 2020
Merged
Conversation
Contributor
|
I'd like to try to write a characterization test given it's an undocumented behavior if this is not urgent - more for my learning than for likelihood of future breakages which is minimal. |
Contributor
Author
|
More meant that it doesn't replicate the same error, rather than being something that unexpected. |
nlisgo
approved these changes
Jan 21, 2020
Contributor
nlisgo
left a comment
There was a problem hiding this comment.
@thewilkybarkid is there a related open issue on the http-errors project. At least to address the documentation?
Contributor
Author
|
Commented at jshttp/http-errors#37 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contrary to its documentation, the
http-errorsmodule doesn't create a new error if it is already an HTTP error, so we don't need to check its type locally.