perf: speed up distinct index collection in low-memory pipeline#711
Open
hjanuschka wants to merge 1 commit intolibjxl:mainfrom
Open
perf: speed up distinct index collection in low-memory pipeline#711hjanuschka wants to merge 1 commit intolibjxl:mainfrom
hjanuschka wants to merge 1 commit intolibjxl:mainfrom
Conversation
Benchmark @ e86a453Comparing: e883140e (Base) vs 0915daeb (PR)
|
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes Option staging in get_distinct_indices and builds the result directly in position order. It reduces overhead in a hot helper used during low-memory pipeline row setup without changing behavior. Unsafe is used only to reborrow previously collected mutable pointers, and is safe because indices are distinct and sorted, so aliasing cannot occur.