Add overflow guard in GetMinSize buffer size calculation#4676
Open
rootvector2 wants to merge 2 commits intolibjxl:mainfrom
Open
Add overflow guard in GetMinSize buffer size calculation#4676rootvector2 wants to merge 2 commits intolibjxl:mainfrom
rootvector2 wants to merge 2 commits intolibjxl:mainfrom
Conversation
Contributor
Author
Member
|
Hi. Please consider using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a small overflow check when computing the output buffer size in GetMinSize().
Although earlier dimension checks already limit image sizes, this guard ensures the multiplication and addition used to compute the final buffer size cannot overflow size_t.
This does not change behavior for valid images and simply adds an extra defensive check.