Skip to content

Allow linking against system libmpack#5

Merged
tarruda merged 1 commit intomasterfrom
allow-linking-against-system-mpack
Jun 24, 2017
Merged

Allow linking against system libmpack#5
tarruda merged 1 commit intomasterfrom
allow-linking-against-system-mpack

Conversation

@tarruda
Copy link
Contributor

@tarruda tarruda commented Jun 23, 2017

Also fix compilation with USE_SYSTEM_LUA=1 introduced by #4

Close #1

@tarruda tarruda force-pushed the allow-linking-against-system-mpack branch 6 times, most recently from d87e91a to 81ae7ab Compare June 23, 2017 14:16
@tarruda
Copy link
Contributor Author

tarruda commented Jun 23, 2017

@jamessan can you test if this PR is enough to fix #1?

@tarruda tarruda force-pushed the allow-linking-against-system-mpack branch from a1fdfdd to 9ddc304 Compare June 23, 2017 14:38
Also fix compilation with USE_SYSTEM_LUA=1 introduced by #4
@tarruda tarruda force-pushed the allow-linking-against-system-mpack branch from 9ddc304 to f3c8bf6 Compare June 23, 2017 14:42
@jamessan
Copy link
Collaborator

I'll check it out tonight.

@chetgurevitch
Copy link
Contributor

chetgurevitch commented Jun 23, 2017

That works on arch linux. I've reworked the package for lua-mpack locally and wrote a new one for libmpack. I'll see about getting those changes into the official repos once this is merged. I also have some changes for the neovim package to bundle fewer dependencies and use ninja that I can try to get upstreamed while I'm at it.

@chetgurevitch
Copy link
Contributor

chetgurevitch commented Jun 24, 2017

Also sorry about the regression, was investigating some weird behavior that turned out to be an issue with arch's lua packaging. The fix just rolled out so behavior should be consistent with other distros now.

@jamessan
Copy link
Collaborator

Works great. Thanks!

@tarruda tarruda merged commit f3c8bf6 into master Jun 24, 2017
tarruda added a commit that referenced this pull request Jun 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow linking against libmpack.so instead of including libmpack amalgamation

3 participants