ci: Install specific protoc version when generating protobufs#3112
Merged
ci: Install specific protoc version when generating protobufs#3112
Conversation
Collaborator
Author
|
merging without another review since this is causing every other PR to fail the check. |
Merged
2color
added a commit
that referenced
this pull request
Jan 24, 2025
…bug-nat-port-mapping * origin/marco/bring-go-nat-home: (75 commits) go mod tidy reference internal package for mockgen mod tidy test-plans Make changes to internal nat library ci: move to actions/upload-artifact@v4 (#3152) tcpreuse: fix rcmgr accounting when tcp metrics are enabled (#3142) fix(net/nat): data race problem of `extAddr` (#3140) test: fix failing test (#3141) quicreuse: make it possible to use an application-constructed quic.Transport (#3122) nat: ignore mapping if external port is 0 (#3094) tcpreuse: error on using tcpreuse with pnet (#3129) chore: Update contribution guidelines (#3134) tcp: fix metrics test build directive (#3052) webrtc: upgrade pion/webrtc to v4 (#3098) ci: get back on the main release track of release checker (#3117) webtransport: fix docstring comment for getCurrentBucketStartTime chore: release v0.38.1 (#3114) fix(httpauth): Correctly handle concurrent requests on server (#3111) ci: Install specific protoc version when generating protobufs (#3112) fix(autorelay): Move relayFinder peer disconnect cleanup to separate goroutine (#3105) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue where CI is using a different version of
protoc/protoc-gen-gofrom our local environment. It downloads the specified version of the protobuf binary for the current system and verifies its hash. Current supported systems are macOS-aarch64 and linux-{x86_64,aarch64}. This is only used when we are regenerating the protobufs, so likely not something we will often run into.Now the generated pbs should be reproducible locally and on CI.