chore(autonat-v2): Fix Spurious Exceptions#3400
Open
ruediste wants to merge 1 commit intolibp2p:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running autonat-v2, exceptions such as the following are printed on the console:
They come from
getNetConfig(), which throws an exception when an address isn't a ip4 or ip6 addr. Those exceptions are quite confusing to a newcomer and should not be logged, as it can be expected that other types of addresses are processed.Notes & open questions
The choice to throw exceptions instead of returning a value for
getNetConfig()seems quite debatable to me...Change checklist