Updating to the newest Spotify API by devgianlu · Pull Request #105 · librespot-org/librespot-java

devgianlu · 2019-07-05T14:40:05Z

This is a pretty consistent PR as we are switching to the new API which relies primarily on HTTPS (finally!).

TODO:

Bugs:

Connection drops from time to time (still haven't figured out what causes that)

…ions + migrating

devgianlu · 2019-07-05T14:48:02Z

@sashahilton00 @ashthespy @kingosticks I thought you might be interested in this. The protocol changes are mainly here, this also contains some insights on what has changed.

ashthespy · 2019-07-11T11:15:47Z

@devgianlu I see you got the websocket dealer also figured out. I didn't look to deeply into the code, but what all is now going through the webgate, and what all is done with mercury? From what I see, you have hm://connect-state/v1/ working?

# Conflicts: # api/src/main/java/xyz/gianlu/librespot/api/Main.java # core/src/main/java/xyz/gianlu/librespot/core/ZeroconfServer.java

loeffelpan · 2019-10-08T20:20:06Z

Did you miss my last post?
So, there are no more ideas my state issue?

However, my iOS App looses connection sometimes when playback starts or after skipping.

devgianlu · 2019-10-08T20:25:26Z

I'm working on it without too much success, but I'm making progress. The connection issue has been annotated, will sort everything out at one point.

…/devgianlu/a41453583be64223412821a61c56690a)

crsmoro · 2019-10-13T20:34:50Z

about this, just a feedback
it seems to be working really fine, my internet connection is really unstable this week, i saw this a couple times.. here is the latest log about it..

2019-10-13 17:24:45 TRACE CdnManager:261 - Chunk 40/60 completed, cdn: audio4-ak-spotify-com.akamaized.net, cached: false, stream: {fileId: 529E26F2F1EFA0C34C5AC38DC1B0CC5453BF06C7}
2019-10-13 17:24:57 DEBUG Player:340 - Playback halted on retrieving chunk 41.
2019-10-13 17:24:58 FATAL CdnManager:299 - Failed requesting chunk from network, index: 41, retried: false
java.net.SocketTimeoutException: timeout
        at okio.SocketAsyncTimeout.newTimeoutException(Okio.kt:159)
        at okio.AsyncTimeout.exit$jvm(AsyncTimeout.kt:203)
        at okio.AsyncTimeout$source$1.read(AsyncTimeout.kt:163)
        at okio.RealBufferedSource.indexOf(RealBufferedSource.kt:349)
        at okio.RealBufferedSource.readUtf8LineStrict(RealBufferedSource.kt:222)
        at okhttp3.internal.http1.Http1ExchangeCodec.readHeaderLine(Http1ExchangeCodec.kt:210)
        at okhttp3.internal.http1.Http1ExchangeCodec.readResponseHeaders(Http1ExchangeCodec.kt:181)
        at okhttp3.internal.connection.Exchange.readResponseHeaders(Exchange.kt:105)
        at okhttp3.internal.http.CallServerInterceptor.intercept(CallServerInterceptor.kt:82)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:112)
        at okhttp3.internal.connection.ConnectInterceptor.intercept(ConnectInterceptor.kt:37)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:112)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:87)
        at okhttp3.internal.cache.CacheInterceptor.intercept(CacheInterceptor.kt:82)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:112)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:87)
        at okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.kt:84)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:112)
        at okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.kt:71)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:112)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:87)
        at okhttp3.RealCall.getResponseWithInterceptorChain(RealCall.kt:184)
        at okhttp3.RealCall.execute(RealCall.kt:66)
        at xyz.gianlu.librespot.player.feeders.cdn.CdnManager$Streamer.request(CdnManager.java:314)
        at xyz.gianlu.librespot.player.feeders.cdn.CdnManager$Streamer.request(CdnManager.java:307)
        at xyz.gianlu.librespot.player.feeders.cdn.CdnManager$Streamer.requestChunk(CdnManager.java:296)
        at xyz.gianlu.librespot.player.feeders.cdn.CdnManager$Streamer.access$6(CdnManager.java:283)
        at xyz.gianlu.librespot.player.feeders.cdn.CdnManager$Streamer$InternalStream.lambda$0(CdnManager.java:366)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at java.lang.Thread.run(Thread.java:748)
Caused by: java.net.SocketException: Socket closed
        at java.net.SocketInputStream.read(SocketInputStream.java:204)
        at java.net.SocketInputStream.read(SocketInputStream.java:141)
        at sun.security.ssl.InputRecord.readFully(InputRecord.java:465)
        at sun.security.ssl.InputRecord.read(InputRecord.java:503)
        at sun.security.ssl.SSLSocketImpl.readRecord(SSLSocketImpl.java:983)
        at sun.security.ssl.SSLSocketImpl.readDataRecord(SSLSocketImpl.java:940)
        at sun.security.ssl.AppInputStream.read(AppInputStream.java:105)
        at okio.InputStreamSource.read(Okio.kt:102)
        at okio.AsyncTimeout$source$1.read(AsyncTimeout.kt:159)
        ... 28 more
2019-10-13 17:25:08 FATAL CdnManager:299 - Failed requesting chunk from network, index: 44, retried: false
java.net.SocketTimeoutException: timeout
        at okio.SocketAsyncTimeout.newTimeoutException(Okio.kt:159)
        at okio.AsyncTimeout.exit$jvm(AsyncTimeout.kt:203)
        at okio.AsyncTimeout$source$1.read(AsyncTimeout.kt:163)
        at okio.RealBufferedSource.indexOf(RealBufferedSource.kt:349)
        at okio.RealBufferedSource.readUtf8LineStrict(RealBufferedSource.kt:222)
        at okhttp3.internal.http1.Http1ExchangeCodec.readHeaderLine(Http1ExchangeCodec.kt:210)
        at okhttp3.internal.http1.Http1ExchangeCodec.readResponseHeaders(Http1ExchangeCodec.kt:181)
        at okhttp3.internal.connection.Exchange.readResponseHeaders(Exchange.kt:105)
        at okhttp3.internal.http.CallServerInterceptor.intercept(CallServerInterceptor.kt:82)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:112)
        at okhttp3.internal.connection.ConnectInterceptor.intercept(ConnectInterceptor.kt:37)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:112)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:87)
        at okhttp3.internal.cache.CacheInterceptor.intercept(CacheInterceptor.kt:82)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:112)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:87)
        at okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.kt:84)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:112)
        at okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.kt:71)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:112)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:87)
        at okhttp3.RealCall.getResponseWithInterceptorChain(RealCall.kt:184)
        at okhttp3.RealCall.execute(RealCall.kt:66)
        at xyz.gianlu.librespot.player.feeders.cdn.CdnManager$Streamer.request(CdnManager.java:314)
        at xyz.gianlu.librespot.player.feeders.cdn.CdnManager$Streamer.request(CdnManager.java:307)
        at xyz.gianlu.librespot.player.feeders.cdn.CdnManager$Streamer.requestChunk(CdnManager.java:296)
        at xyz.gianlu.librespot.player.feeders.cdn.CdnManager$Streamer.access$6(CdnManager.java:283)
        at xyz.gianlu.librespot.player.feeders.cdn.CdnManager$Streamer$InternalStream.lambda$0(CdnManager.java:366)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at java.lang.Thread.run(Thread.java:748)
Caused by: java.net.SocketException: Socket closed
        at java.net.SocketInputStream.read(SocketInputStream.java:204)
        at java.net.SocketInputStream.read(SocketInputStream.java:141)
        at sun.security.ssl.InputRecord.readFully(InputRecord.java:465)
        at sun.security.ssl.InputRecord.read(InputRecord.java:503)
        at sun.security.ssl.SSLSocketImpl.readRecord(SSLSocketImpl.java:983)
        at sun.security.ssl.SSLSocketImpl.readDataRecord(SSLSocketImpl.java:940)
        at sun.security.ssl.AppInputStream.read(AppInputStream.java:105)
        at okio.InputStreamSource.read(Okio.kt:102)
        at okio.AsyncTimeout$source$1.read(AsyncTimeout.kt:159)
        ... 28 more
2019-10-13 17:25:15 WARN  DealerClient:270 - Did not receive ping in 3 seconds. Reconnecting...
2019-10-13 17:25:15 TRACE DealerClient:176 - Scheduled reconnection attempt in 10 seconds...
2019-10-13 17:25:21 TRACE CdnManager:261 - Chunk 43/60 completed, cdn: audio4-ak-spotify-com.akamaized.net, cached: false, stream: {fileId: 529E26F2F1EFA0C34C5AC38DC1B0CC5453BF06C7}

devgianlu · 2019-10-14T11:20:11Z

@crsmoro Would you say it is fine now? Did it recover each time the connection dropped?

crsmoro · 2019-10-14T11:29:43Z

yes, it did

sashahilton00 · 2019-10-17T02:22:46Z

@devgianlu did you get the dealer stuff working with the {"type":"ping"} requests at 30 second intervals? I had a look at #140 and the traffic that i intercept, there is nothing that looks like an ack_id for play.spotify.com wss service, and I see no dealer traffic from the desktop client, so not really sure where the dealer stuff might be coming from?

l3d00m · 2019-10-20T17:27:16Z

I hope it's correct to report it here: The podcasts in mixed playlists aka "Daily Drive" are only played sometimes for me. If I start streaming while I'm already in the playlist, it works like it should, but if I'm in a normal playlist and then switch to the mixed playlist, all included podcasts are skipped.

I'm using the newest commit for this (3088373)

devgianlu · 2019-10-22T19:56:06Z

if I'm in a normal playlist and then switch to the mixed playlist, all included podcasts are skipped.

@l3d00m Can't reproduce it, could you provide a log?

devgianlu · 2019-11-01T14:37:05Z

Since #140 has been solved. I'll start squashing the last remaining bugs and hopefully merge this into a new development branch (inspired by librespot-org/librespot#385) by the end of the week.

devgianlu · 2019-11-25T10:47:24Z

I've just released 1.0.0.

devgianlu added 12 commits June 10, 2019 19:43

Refactored ApResolver + added dealer and api clients

40e8b83

Fixed build error

b95015b

Merge branch 'master' into new-spotify-api

5a7ec9e

Disabled IRC + working device dispatch

f8d61ec

Clean up + in/out messages

071fa45

Fixed build

e8b001b

Cleaned up the damn thing (removed ALL old logic) + new proto definit…

1941512

…ions + migrating

Started parsing player command

11fcca3

Very buggy, features are missing, BUT IT WORKS

d0dddcc

Some playback improvements

3461e65

Rudimentary prev/next support (not with buttons)

86f834a

Re-adding player functionalities (playback still pretty buggy)

98c5b0c

devgianlu added the enhancement New feature or request label Jul 5, 2019

More logic + brought back Play event

3408a63

devgianlu added 14 commits July 5, 2019 17:52

Refactored CdnManager and TokenProvider

5c40ec5

Removed useless proto definitions

87ad93a

Minor clean up + fixed loading paused song

d5ff5be

Fixed race condition in DealerClient

6e8aefd

Moved duration update to correct place

555a97a

Minor refactoring

ea433f9

Removed some debug lines

5f198db

Put everything we know about the track/episode in the metadata

e1b7a91

Minor changes and fixes

86d2292

Restrictions + repeat context/track + fixed #100

73125c3

Shuffle/unshuffle + tweaked next/prev logic

8765fc2

Skip unsupported elements

ff2cc35

Handle most queue operations

18d7ef3

Handling SetQueue and Transfer with queue

b4b0e5a

devgianlu added 4 commits October 8, 2019 15:16

Retry AudioKey request

07b68d9

Refactored callback mechanism + minor fixes

c52eae8

Avoid reconnection attempt if session is already valid (Zeroconf)

602c4e1

Merge branch 'master' into new-spotify-api

8f1ed98

# Conflicts: # api/src/main/java/xyz/gianlu/librespot/api/Main.java # core/src/main/java/xyz/gianlu/librespot/core/ZeroconfServer.java

devgianlu added 3 commits October 9, 2019 14:40

Refactored ZeroconfServer + updated versions (https://gist.github.com…

150ca2f

…/devgianlu/a41453583be64223412821a61c56690a)

Fixed Android crash when using autoplay

870953a

Some clean up

8357d98

devgianlu mentioned this pull request Oct 11, 2019

instance does not play anything after some time of idleness #134

Closed

Added workaround for multiple transfer requests (#140)

3088373

devgianlu mentioned this pull request Oct 26, 2019

NullPointerExcetion in StateWrapper.java #146

Closed

Implemented command ack logic (#140) + use desktop build info

441c8bf

devgianlu added 3 commits November 1, 2019 19:15

Fixed volume issue + do not notify state when receiving a cluster update

3845b73

Fixed repeating track when crossfade is enabled

0ff1d39

Fixed broken player if seeking during crossfade

1963f70

devgianlu changed the base branch from master to dev November 2, 2019 10:29

devgianlu closed this Nov 2, 2019

devgianlu reopened this Nov 2, 2019

devgianlu merged commit c4f9e9e into dev Nov 2, 2019

devgianlu deleted the new-spotify-api branch November 2, 2019 10:33

devgianlu mentioned this pull request Aug 18, 2020

Lots of failing songs - "Error from channel for data receiver" librespot-org/librespot#519

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Updating to the newest Spotify API#105

Updating to the newest Spotify API#105
devgianlu merged 161 commits intodevfrom
new-spotify-api

devgianlu commented Jul 5, 2019 •

edited

Loading

Uh oh!

devgianlu commented Jul 5, 2019 •

edited

Loading

Uh oh!

ashthespy commented Jul 11, 2019

Uh oh!

loeffelpan commented Oct 8, 2019 •

edited

Loading

Uh oh!

devgianlu commented Oct 8, 2019

Uh oh!

crsmoro commented Oct 13, 2019

Uh oh!

devgianlu commented Oct 14, 2019

Uh oh!

crsmoro commented Oct 14, 2019

Uh oh!

sashahilton00 commented Oct 17, 2019

Uh oh!

l3d00m commented Oct 20, 2019

Uh oh!

devgianlu commented Oct 22, 2019

Uh oh!

devgianlu commented Nov 1, 2019

Uh oh!

devgianlu commented Nov 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Uh oh!

Conversation

devgianlu commented Jul 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devgianlu commented Jul 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ashthespy commented Jul 11, 2019

Uh oh!

loeffelpan commented Oct 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devgianlu commented Oct 8, 2019

Uh oh!

crsmoro commented Oct 13, 2019

Uh oh!

devgianlu commented Oct 14, 2019

Uh oh!

crsmoro commented Oct 14, 2019

Uh oh!

sashahilton00 commented Oct 17, 2019

Uh oh!

l3d00m commented Oct 20, 2019

Uh oh!

devgianlu commented Oct 22, 2019

Uh oh!

devgianlu commented Nov 1, 2019

Uh oh!

devgianlu commented Nov 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

devgianlu commented Jul 5, 2019 •

edited

Loading

devgianlu commented Jul 5, 2019 •

edited

Loading

loeffelpan commented Oct 8, 2019 •

edited

Loading