Make device id configurable#178
Merged
devgianlu merged 3 commits intolibrespot-org:devfrom Mar 6, 2020
funtax:make_deviceId_configurable
Merged
Make device id configurable#178devgianlu merged 3 commits intolibrespot-org:devfrom funtax:make_deviceId_configurable
devgianlu merged 3 commits intolibrespot-org:devfrom
funtax:make_deviceId_configurable
Conversation
Member
|
I think this is not what you're looking for, but rather this. The device ID you are modifying is used only by Spotify and isn't related with MDNS. |
Contributor
Author
|
Thanks for checking. I am not publishing the devices via the bundled ZeroconfServer but via a custom (Apple) MDNS-library. Additionally, I am publishing the devices via MDNS and having them authenticated at the same time. Having the deviceId randomly generated within the package-private Inner-class causes a lot of trouble as I need the value for "getInfo" before the Session is created. As the Inner-Class (and more) is package-private and cannot be used outside your package. If one is able to provide the deviceId this would make things more flexible :-) |
Contributor
Author
|
Thank you very much! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my situation, I create multiple instances of librespot-java and each instance can randomly appear & disappear.
To avoid confusion with the deviceId's (mdns), I have to set a persistent deviceId for each instance so an instance doesn't appear twice with the same name and different deviceId.
Please allow to set a permantent deviceId.