Extracted AsyncWorker we can use for multiple consumers in code base.#206
Merged
devgianlu merged 4 commits intolibrespot-org:devfrom Apr 13, 2020
Merged
Extracted AsyncWorker we can use for multiple consumers in code base.#206devgianlu merged 4 commits intolibrespot-org:devfrom
devgianlu merged 4 commits intolibrespot-org:devfrom
Conversation
devgianlu
approved these changes
Apr 13, 2020
Member
|
Is there a way we could implement an await feature? Some threads need to complete their network requests before shutting down. |
Contributor
Author
|
I submitted a PR - let me know what you think. I am tempted to just use a
single threaded executor inside AsyncProcessor. Much cleaner that managing
our own threads.
…On Sun, Apr 19, 2020 at 2:56 PM devgianlu ***@***.***> wrote:
Is there a way we could implement an await feature? Some threads need to
complete their network requests before shutting down.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#206 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEL7CQFROQ6SBBTO2QVECTRNNCPDANCNFSM4MGUN77A>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.