Set the correct platform tag for macOS wheels#378
Merged
Conversation
hombit
force-pushed
the
macosx-deployment-target
branch
from
f0db576 to
4cb1c21
Compare
CodSpeed Performance ReportMerging #378 will not alter performanceComparing Summary
|
hombit
force-pushed
the
macosx-deployment-target
branch
from
4cb1c21 to
ae90cf5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #378 +/- ##
=======================================
Coverage 82.63% 82.63%
=======================================
Files 9 9
Lines 2574 2574
=======================================
Hits 2127 2127
Misses 447 447 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dynamic libraries installed from Homebrew are targeted to the current macOS version, so our wheels are. This PR fixes wheel tags to correspond to the macOS versions we use in CI. This fixes #376, but doesn't solve the problem of older macOS version support.
From CI it looks like it is not solved right now, but hopefully will be solved with #370