Skip to content

Fix error messages for invalid inputs#510

Merged
hombit merged 1 commit intomasterfrom
fix-casting-exceptions
Apr 25, 2025
Merged

Fix error messages for invalid inputs#510
hombit merged 1 commit intomasterfrom
fix-casting-exceptions

Conversation

@hombit
Copy link
Member

@hombit hombit commented Apr 25, 2025

Fix #505

@hombit hombit enabled auto-merge April 25, 2025 19:58
@codecov
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.80%. Comparing base (6d804da) to head (286d2c3).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
light-curve/src/np_array.rs 94.11% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #510      +/-   ##
==========================================
- Coverage   82.06%   81.80%   -0.27%     
==========================================
  Files           9        9              
  Lines        2570     2577       +7     
==========================================
- Hits         2109     2108       -1     
- Misses        461      469       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hombit hombit disabled auto-merge April 25, 2025 20:04
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 25, 2025

CodSpeed Performance Report

Merging #510 will degrade performances by 30.17%

Comparing fix-casting-exceptions (286d2c3) with master (6d804da)

Summary

❌ 17 regressions
✅ 87 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_benchmark_cesium 12.7 ms 14.8 ms -13.86%
test_benchmark_cesium 5.3 ms 7.5 ms -29.23%
test_benchmark_cesium 6.3 ms 8.5 ms -25.52%
test_benchmark_cesium 5.4 ms 7.5 ms -28.64%
test_benchmark_cesium 5.3 ms 7.5 ms -28.91%
test_benchmark_cesium 5.3 ms 7.5 ms -28.89%
test_benchmark_cesium 5.4 ms 7.5 ms -28.96%
test_benchmark_cesium 5.2 ms 7.4 ms -29.66%
test_benchmark_cesium 5 ms 7.2 ms -30.17%
test_benchmark_cesium 5.1 ms 7.3 ms -30.11%
test_benchmark_cesium 5.2 ms 7.4 ms -29.79%
test_benchmark_cesium 5.2 ms 7.4 ms -29.5%
test_benchmark_cesium 5.3 ms 7.5 ms -29.02%
test_benchmark_cesium 5.9 ms 8.1 ms -26.98%
test_benchmark_cesium 5.1 ms 7.3 ms -29.91%
test_benchmark_cesium 6.9 ms 9 ms -23.92%
test_benchmark_cesium 5.2 ms 7.3 ms -29.71%

@hombit hombit force-pushed the fix-casting-exceptions branch from 37fdb72 to 286d2c3 Compare April 25, 2025 20:25
@hombit hombit enabled auto-merge April 25, 2025 20:35
@hombit hombit merged commit c9b1728 into master Apr 25, 2025
49 of 50 checks passed
@hombit hombit deleted the fix-casting-exceptions branch April 25, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misleading error message for non-1d arrays

1 participant