rebalance, feeadjuster, drain, jitrebalance: fix for next release.#276
Merged
rustyrussell merged 4 commits intolightningd:masterfrom Jul 23, 2021
Merged
rebalance, feeadjuster, drain, jitrebalance: fix for next release.#276rustyrussell merged 4 commits intolightningd:masterfrom
rustyrussell merged 4 commits intolightningd:masterfrom
Conversation
We now insist on payment_secret, so rebalance fails! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Member
|
Thanks, we also need to apply this for: drain, feeadjuster (tests), jitrebalance and probe. |
m-schmoock
approved these changes
Jul 23, 2021
Member
m-schmoock
left a comment
m-schmoock
left a comment
There was a problem hiding this comment.
tACK d96e84f
Successfully tested with versions lower and higher than ElementsProject/lightning@3f5d5a1de that have and have not the paymanet_secret in the invoice. This works for both because payment_secret is an optional parameter for sendpay and can be (intentionally) None if it was not contained in the invoice before.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…ecret Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…secret Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Collaborator
Author
|
Good catch, did those too! AFAICT, probes always use made up payment_hashes anyway though... |
rustyrussell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now insist on payment_secret, so rebalance fails!