Make build output deterministic by remapping paths #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
force-pushed
the
2021-03-deterministic-bins
branch
7 times, most recently
from
73a0b80 to
29abeb3
Compare
TheBlueMatt
force-pushed
the
2021-03-deterministic-bins
branch
from
29abeb3 to
2466f10
Compare
Collaborator
Author
|
I think I addressed the specific requests. |
valentinewallace
approved these changes
Mar 24, 2021
valentinewallace
left a comment
valentinewallace
left a comment
There was a problem hiding this comment.
LGTM 💯
Note: getting this possibly new warning:
+ clang++ -Wall -Wno-nullability-completeness -pthread -flto -fuse-ld=lld -O2 demo.cpp target/release/libldk.a -ldl
ld.lld: warning: Linking two modules of different target triples: target/release/libldk.a(secp256k1.o at 9360636)' is 'x86_64-unknown-linux-gnu' whereas 'ld-temp.
o' is 'x86_64-pc-linux-gnu'
2466f10 to
c41808a
Compare
Collaborator
Author
Yes, I'm pretty sure it doesn't matter given they're both x86_64-linux-gnu, its just a difference in how cc-rs manages rust's target triple into clang's target triple. Fixed the other comments with the changes being exactly the diff suggested by Val, above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.