Change print to logging in index#154
Merged
Merged
Conversation
Collaborator
|
You will need to update the docstrings in order to make the tests pass I think so :) |
Contributor
Author
|
I've updated test. One of the tests failing due to HF rate limits |
Collaborator
Yeah, it's a pain these days, have to relaunch a few times for them to run...
You mean the utils of stanford-nlp plaid index? It should not really be an issue because the index will slowly be deprecated to use fast-plaid, but we might want to clean logging still Edit: Edit2: I merged so we can release the new version, tell me if this was required for something |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also wanted to add
T20to ruff rules, but in utils folder a lot of prints, so I'm not sure how to deal with them