Skip to content

Change print to logging in index#154

Merged
NohTow merged 2 commits into
lightonai:mainfrom
Samoed:remove_print
Sep 23, 2025
Merged

Change print to logging in index#154
NohTow merged 2 commits into
lightonai:mainfrom
Samoed:remove_print

Conversation

@Samoed
Copy link
Copy Markdown
Contributor

@Samoed Samoed commented Sep 18, 2025

I also wanted to add T20 to ruff rules, but in utils folder a lot of prints, so I'm not sure how to deal with them

@raphaelsty
Copy link
Copy Markdown
Collaborator

You will need to update the docstrings in order to make the tests pass I think so :)

@Samoed
Copy link
Copy Markdown
Contributor Author

Samoed commented Sep 23, 2025

I've updated test. One of the tests failing due to HF rate limits

@NohTow
Copy link
Copy Markdown
Collaborator

NohTow commented Sep 23, 2025

One of the tests failing due to HF rate limits

Yeah, it's a pain these days, have to relaunch a few times for them to run...

but in utils folder a lot of prints, so I'm not sure how to deal with them

You mean the utils of stanford-nlp plaid index? It should not really be an issue because the index will slowly be deprecated to use fast-plaid, but we might want to clean logging still

Edit:
Tests are passing, we can merge except if you want to handle utils right now

Edit2: I merged so we can release the new version, tell me if this was required for something

@NohTow NohTow merged commit 2c702c0 into lightonai:main Sep 23, 2025
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants