Update CI, bump fast-plaid to 1.4.4, and add low_memory parameter#204
Update CI, bump fast-plaid to 1.4.4, and add low_memory parameter#204raphaelsty wants to merge 5 commits intomainfrom
Conversation
1086f92 to
135dade
Compare
|
Investigating how to make fast-plaid compatible with python 3.14 version Blocker encountered with tch-rs, it's ok for now to not support python 3.14, we will as soon as tch-rs support recent PyO3 version |
|
I see you hit the tch-rs wall for 3.14 support. I've been poking at the same issue. I managed to get fast-plaid built and running on 3.14 with the ABI3 compatibility flag. Built a wheel locally and ran the PyLate and fast-plaid test suites and all pass. This would just need to be added to That would be a no-op for <3.14 and your existing I'd get it if if you'd prefer to wait for tch-rs to properly support PyO3 0.28, but if you want to unblock 3.14 now I can throw together a PR for fast-plaid#37. |
|
You rock @mchar7, would love to get a PR with the CIBW flag, thank you for the feedback |
Drop Python 3.9 (deprecated in Sentence Transformers) and 3.12 to only test the lower and upper bounds of supported versions, keeping CI fast. Also remove --extra voyager from test runs since the Voyager index is being deprecated and was causing failures on Python 3.14. Closes #185 Co-Authored-By: Roman Solomatin <samoed.roman@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5182ce9 to
edd725d
Compare
|
I pushed a few commits on top of your branch to get the 3.14 tests green.
All workflows passing: CI run (mchar7#1). Branch is at mchar7/pylate:python314-fix (https://github.com/mchar7/pylate/tree/python314-fix) if you want to scan through. |
Summary
>=1.4.4.270,<=1.4.4.290low_memoryparameter toFastPlaidindex (defaults toFalsefor faster GPU search)Changes
pyproject.toml: Updated fast-plaid version rangepylate/indexes/fast_plaid.py: Addedlow_memoryparameter with docstring, passed through tosearch.FastPlaid()