Closed
Conversation
jmacd
added a commit
to lightstep/varopt
that referenced
this pull request
Nov 29, 2023
This code was last updated before Go generics. It's an obvious win here, and was easy to do. Also adds CopyFrom() and Init() method in support of lightstep/otel-launcher-go#576 and new tests.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #576 +/- ##
==========================================
- Coverage 89.60% 89.09% -0.52%
==========================================
Files 62 64 +2
Lines 3686 4007 +321
==========================================
+ Hits 3303 3570 +267
- Misses 285 334 +49
- Partials 98 103 +5 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Recent benchmarks: AFTER If we take the best-case performance and study the before/after with trace enabled, it appears similar. For example, BenchmarkCounterAddNoAttrs-10 rises from 45ns to 60ns. |
5 tasks
8413826 to
3684834
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
First implementation of the OpenTelemetry metrics SDK exemplar specification in the LS Metrics SDK.
This implements the specified exemplar filter mechanism.
This implements two exemplar reservoirs, one named
Lastand one namedWeighted.Last picks a single exemplar, the most recent.
Weighted uses the VarOpt algorithm from https://github.com/lightstep/varopt.
Depends on lightstep/varopt#20Link to tracking Issue:
#575
Testing: New tests.
Documentation: New documentation. The new functionality is labeled as experimental.