Skip to content

Add slack message when smoke test fails#455

Open
OmBiradar wants to merge 3 commits intolincc-frameworks:mainfrom
OmBiradar:slack_message_on_smoke_failure
Open

Add slack message when smoke test fails#455
OmBiradar wants to merge 3 commits intolincc-frameworks:mainfrom
OmBiradar:slack_message_on_smoke_failure

Conversation

@OmBiradar
Copy link

Change Description

Closes #453

Solution Description

Slack has an officially maintained github actions service that can be used here.
It sends the message directly to the designated slack channel.

It needs a secret to be added to the repo - the SLACK_WEBHOOK_URL which can be generated form the slack app itself.

Reference for the code: Official slack documentation

Code Quality

  • I have read the Contribution Guide and agree to the Code of Conduct
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Signed-off-by: OmBiradar <ombiradar04@gmail.com>
@OmBiradar
Copy link
Author

Please could you review it @dougbrn

Copy link
Collaborator

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good first attempt, especially given the lack of information in the issue, just some comments

webhook: ${{ secrets.SLACK_WEBHOOK_URL }}
webhook-type: incoming-webhook
payload: |
text: "Smoke test failed ${{ matrix.python-version }}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original issue really didn't have much context, but to offer some additional context this slack report goes to a channel with multiple repositories reporting, so we would want to also provide the repository name

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have to look into the formatting of this slack message. Online docs don't proove to be that helpfull in understanding the structure. Might take some time.

@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.30%. Comparing base (39a4681) to head (c72a410).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #455   +/-   ##
=======================================
  Coverage   97.30%   97.30%           
=======================================
  Files          19       19           
  Lines        2156     2156           
=======================================
  Hits         2098     2098           
  Misses         58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

Before [39a4681] After [c752a61] Ratio Benchmark (Parameter)
29.8±1ms 30.3±2ms 1.02 benchmarks.AssignSingleDfToNestedSeries.time_run
10.8±0.09ms 11.0±0.2ms 1.02 benchmarks.NestedFrameQuery.time_run
1.17G 1.19G 1.02 benchmarks.ReadFewColumnsS3.peakmem_run
66.1±0.9ms 66.9±0.5ms 1.01 benchmarks.CountNestedBy.time_run
177M 179M 1.01 benchmarks.ReadFewColumnsHTTPS.peakmem_run
257M 255M 1 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
159±90ms 160±90ms 1 benchmarks.ReadFewColumnsHTTPS.time_run
263M 265M 1 benchmarks.ReassignHalfOfNestedSeries.peakmem_run
140M 136M 0.98 benchmarks.CountNestedBy.peakmem_run
105M 103M 0.98 benchmarks.NestedFrameAddNested.peakmem_run

Click here to view all benchmarks.

@OmBiradar
Copy link
Author

Looks like a good first attempt, especially given the lack of information in the issue, just some comments

thanks! it actually felt straight forward.

Signed-off-by: OmBiradar <ombiradar04@gmail.com>
Signed-off-by: OmBiradar <ombiradar04@gmail.com>
@OmBiradar
Copy link
Author

Hey @dougbrn, can you please create a testing channel for

  • testing if this actually works and
  • if the formatting is good enough.

It would be great if you could give me permission to open up a slack channel and work with my own slack webhook uri on that channel on my personal fork of the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Send slack message on smoke test failure.

2 participants