Add slack message when smoke test fails#455
Add slack message when smoke test fails#455OmBiradar wants to merge 3 commits intolincc-frameworks:mainfrom
Conversation
Signed-off-by: OmBiradar <ombiradar04@gmail.com>
|
Please could you review it @dougbrn |
dougbrn
left a comment
There was a problem hiding this comment.
Looks like a good first attempt, especially given the lack of information in the issue, just some comments
.github/workflows/smoke-test.yml
Outdated
| webhook: ${{ secrets.SLACK_WEBHOOK_URL }} | ||
| webhook-type: incoming-webhook | ||
| payload: | | ||
| text: "Smoke test failed ${{ matrix.python-version }}" |
There was a problem hiding this comment.
The original issue really didn't have much context, but to offer some additional context this slack report goes to a channel with multiple repositories reporting, so we would want to also provide the repository name
There was a problem hiding this comment.
I would have to look into the formatting of this slack message. Online docs don't proove to be that helpfull in understanding the structure. Might take some time.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #455 +/- ##
=======================================
Coverage 97.30% 97.30%
=======================================
Files 19 19
Lines 2156 2156
=======================================
Hits 2098 2098
Misses 58 58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Click here to view all benchmarks. |
thanks! it actually felt straight forward. |
Signed-off-by: OmBiradar <ombiradar04@gmail.com>
Signed-off-by: OmBiradar <ombiradar04@gmail.com>
|
Hey @dougbrn, can you please create a testing channel for
It would be great if you could give me permission to open up a slack channel and work with my own slack webhook uri on that channel on my personal fork of the project. |
Change Description
Closes #453
Solution Description
Slack has an officially maintained github actions service that can be used here.
It sends the message directly to the designated slack channel.
It needs a
secretto be added to the repo - theSLACK_WEBHOOK_URLwhich can be generated form the slack app itself.Reference for the code: Official slack documentation
Code Quality