This repository was archived by the owner on Jul 1, 2025. It is now read-only.
feat: logger switch feature is added#86
Merged
xymz merged 6 commits intoline:release/v1.4.0from Jan 3, 2023
chansun:release/v1.4.0
Merged
feat: logger switch feature is added#86xymz merged 6 commits intoline:release/v1.4.0from chansun:release/v1.4.0
xymz merged 6 commits intoline:release/v1.4.0from
chansun:release/v1.4.0
Conversation
ryukato
reviewed
Jan 3, 2023
xymz
reviewed
Jan 3, 2023
xymz
reviewed
Jan 3, 2023
ryukato
approved these changes
Jan 3, 2023
xymz
approved these changes
Jan 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
What is the current behavior?
HttpClient instance's logging feature for request/response is always on and cannot be turned off on the .spec file level.
What is the new behavior?
HttpClient instance's logging feature now has a switch to turn on and off the logging feature for request/response.
Other information
e.g., In a spec file, you may choose to turn off logging feature like this.
...
const httpClient = new HttpClient(HOST_URL, SERVICE_API_KEY, SERVICE_API_SECRET); // logging feature is on by default.
httpClient.logOff(); // turn off the logging feature and no more logs are printed
...