fix(ember-cli): Use separate file for CSS staging, merge app.css at end.#230
Merged
amiller-gh merged 2 commits intomasterfrom Feb 21, 2019
Merged
fix(ember-cli): Use separate file for CSS staging, merge app.css at end.#230amiller-gh merged 2 commits intomasterfrom
amiller-gh merged 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When integrating with tools like Eyeglass, the CSS preprocessors occasionally rely on the
app.csssymlink chain for module lookup. Previously, the ember-cli addon used the output app.[s]css file as the aggregate file between CSS Blocks addon instances. By using a new file, and merging at the very end of the build, we preserve the Broccoli symlink chain, getting out of the way of preprocessor builds.