Data service #94

dry71 · 2021-07-17T09:25:55Z

Added a DataService file containing the BetterBotBaseDataService class

…Service class

lgtm-com · 2021-07-17T09:34:50Z

This pull request introduces 1 alert and fixes 1 when merging 843e465 into 96f579a - view on LGTM.com

new alerts:

1 for Missing call to `__init__` during object initialization

fixed alerts:

1 for Unused import

lgtm-com · 2021-07-17T13:24:57Z

This pull request introduces 1 alert and fixes 1 when merging 8b44aa0 into 96f579a - view on LGTM.com

new alerts:

1 for Missing call to `__init__` during object initialization

fixed alerts:

1 for Unused import

lgtm-com · 2021-07-17T15:28:52Z

This pull request introduces 2 alerts and fixes 1 when merging fca5eaf into 96f579a - view on LGTM.com

new alerts:

1 for Missing call to `__init__` during object initialization
1 for Wrong number of arguments in a call

fixed alerts:

1 for Unused import

lgtm-com · 2021-07-17T16:06:33Z

This pull request introduces 2 alerts and fixes 1 when merging e428403 into 96f579a - view on LGTM.com

new alerts:

1 for Missing call to `__init__` during object initialization
1 for Wrong number of arguments in a call

fixed alerts:

1 for Unused import

lgtm-com · 2021-07-17T18:25:23Z

This pull request introduces 3 alerts and fixes 1 when merging 8fd563c into 96f579a - view on LGTM.com

new alerts:

1 for Unused import
1 for Missing call to `__init__` during object initialization
1 for Wrong number of arguments in a call

fixed alerts:

1 for Unused import

lgtm-com · 2021-07-18T15:56:45Z

This pull request introduces 3 alerts and fixes 1 when merging 4363cb5 into 3f51487 - view on LGTM.com

new alerts:

1 for Unused import
1 for Missing call to `__init__` during object initialization
1 for Wrong number of arguments in a call

fixed alerts:

1 for Unused import

lgtm-com · 2021-08-06T17:31:56Z

This pull request introduces 2 alerts and fixes 1 when merging ddb58ab into 3f51487 - view on LGTM.com

new alerts:

1 for Missing call to `__init__` during object initialization
1 for Wrong number of arguments in a call

fixed alerts:

1 for Unused import

lgtm-com · 2021-08-06T20:34:14Z

This pull request introduces 1 alert and fixes 1 when merging e7c3746 into 3f51487 - view on LGTM.com

new alerts:

1 for Wrong number of arguments in a call

fixed alerts:

1 for Unused import

lgtm-com · 2021-08-07T10:02:04Z

This pull request introduces 1 alert and fixes 1 when merging 79e0108 into 3f51487 - view on LGTM.com

new alerts:

1 for Wrong number of arguments in a call

fixed alerts:

1 for Unused import

lgtm-com · 2021-08-08T12:33:47Z

This pull request fixes 1 alert when merging 3cc0aec into 3f51487 - view on LGTM.com

fixed alerts:

1 for Unused import

lgtm-com · 2021-08-08T13:06:01Z

This pull request fixes 1 alert when merging fee2c8a into 3f51487 - view on LGTM.com

fixed alerts:

1 for Unused import

lgtm-com · 2021-08-08T15:53:59Z

This pull request fixes 1 alert when merging a05d7ff into c9cc5a0 - view on LGTM.com

fixed alerts:

1 for Unused import

lgtm-com · 2021-08-21T19:50:36Z

This pull request fixes 1 alert when merging 337d689 into c9cc5a0 - view on LGTM.com

fixed alerts:

1 for Unused import

lgtm-com · 2021-09-11T13:33:41Z

This pull request fixes 1 alert when merging 8fbcdc2 into 85e996e - view on LGTM.com

fixed alerts:

1 for Unused import

lgtm-com · 2021-09-11T13:44:11Z

This pull request fixes 1 alert when merging b725a75 into 85e996e - view on LGTM.com

fixed alerts:

1 for Unused import

konard · 2021-10-23T09:28:11Z

python/__main__.py

+    def get_github_profile_string(self, user):
+        profile = self.data.get_user_property(user, "github_profile")
+        return f"github.com/{profile}" if profile else "отсутствует"

    def get_github_profile_top_string(self, user):
-        profile = self.get_github_profile(user)
-        if profile:
-            profile = f" — github.com/{profile}"
-        return profile
+        profile = self.data.get_user_property(user, "github_profile")
+        return f" — github.com/{profile}" if profile else ""


Suggested change

def get_github_profile_string(self, user):

profile = self.data.get_user_property(user, "github_profile")

return f"github.com/{profile}" if profile else "отсутствует"

def get_github_profile_top_string(self, user):

profile = self.get_github_profile(user)

if profile:

profile = f" — github.com/{profile}"

return profile

profile = self.data.get_user_property(user, "github_profile")

return f" — github.com/{profile}" if profile else ""

def get_github_profile_or_default(self, user, default="", prefix=""):

profile = self.data.get_user_property(user, "github_profile")

return f"{prefix}github.com/{profile}" if profile else default

konard · 2021-10-23T09:30:51Z

python/__main__.py

+        self.data.set_user_property(user, "karma", self.data.get_user_property(user, "karma") + amount)
+        initial_karma = self.data.get_user_property(user, "karma"),
+        self.data.set_user_property(user, "karma", initial_karma + amount)
+        return (user.uid,
+                self.data.get_user_property(user, "name"),
+                initial_karma,
+                self.data.get_user_property(user, "karma"))


Suggested change

self.data.set_user_property(user, "karma", self.data.get_user_property(user, "karma") + amount)

initial_karma = self.data.get_user_property(user, "karma"),

self.data.set_user_property(user, "karma", initial_karma + amount)

return (user.uid,

self.data.get_user_property(user, "name"),

initial_karma,

self.data.get_user_property(user, "karma"))

initial_karma = self.data.get_user_property(user, "karma"),

new_karma = initial_karma + amount;

self.data.set_user_property(user, "karma", new_karma)

return (user.uid,

self.data.get_user_property(user, "name"),

initial_karma,

new_karma)

konard · 2021-10-23T09:33:34Z

python/DataService.py

+    def get_users_sorted_by_keys(self, other_keys, sort_key=None):
+        users = self.base.getByKeys(*other_keys)
+        sorted_users = sorted(
+            users,
+            key=sort_key,
+            reverse=True
+        )
+        return sorted_users


Suggested change

def get_users_sorted_by_keys(self, other_keys, sort_key=None):

users = self.base.getByKeys(*other_keys)

sorted_users = sorted(

users,

key=sort_key,

reverse=True

)

return sorted_users

def get_users(self, other_keys, sort_key=None):

users = self.base.getByKeys(*other_keys)

if sort_key is not None:

users = sorted(

users,

key=sort_key,

reverse=True

)

return users

konard · 2021-10-23T09:34:42Z

python/DataService.py

+    def get_user_sorted_programming_languages(self, user):
+        languages = self.get_user_property(user, "programming_languages")
+        languages = languages if type(languages) == list else []
+        languages.sort()
+        return languages


Suggested change

def get_user_sorted_programming_languages(self, user):

languages = self.get_user_property(user, "programming_languages")

languages = languages if type(languages) == list else []

languages.sort()

return languages

def get_user_programming_languages(self, user, sort=True):

languages = self.get_user_property(user, "programming_languages")

languages = languages if type(languages) == list else []

if sort:

languages.sort()

return languages

lgtm-com · 2021-12-01T11:24:46Z

This pull request fixes 1 alert when merging 6552f9b into c021e09 - view on LGTM.com

fixed alerts:

1 for Unused import

lgtm-com · 2021-12-01T11:34:41Z

This pull request fixes 1 alert when merging b676737 into c021e09 - view on LGTM.com

fixed alerts:

1 for Unused import

lgtm-com · 2021-12-01T12:34:35Z

This pull request fixes 1 alert when merging a662989 into c021e09 - view on LGTM.com

fixed alerts:

1 for Unused import

dry71 added 4 commits July 17, 2021 01:55

Add DataService.py, update __main__.py

0097a3b

fix commands: PEOPLE and TOP

5d7239f

the "update" command has been changed

070fe4a

the update_user_name function has been added to the BetterBotBaseData…

843e465

…Service class

dry71 added 2 commits July 17, 2021 19:14

changed base to data and added the get_github_profile_string method

36338e2

removed the get_github_profile_string method

8b44aa0

dry71 added 3 commits July 17, 2021 21:12

moved the methods

fd79366

moved the methods

236988c

moved the methods

fca5eaf

update

e428403

added the get_user_property and set_user_property methods

8fd563c

dry71 added 2 commits July 18, 2021 21:36

rename methods and changed get_user_sorted_programming_languages

5786a4b

renamed from_id to user_id

4363cb5

moved the methods

ddb58ab

dry71 added 2 commits August 7, 2021 02:13

inheritance changed to composition and the correction of some errors

174ce11

error correction

e7c3746

dry71 added 2 commits August 7, 2021 15:52

error correction

b15926c

Merge remote-tracking branch 'origin/DataService' into DataService

79e0108

dry71 added 2 commits August 8, 2021 18:08

error correction

7d4ee02

changed append and remove

3cc0aec

error correction

fee2c8a

minor fixes

a05d7ff

update

337d689

update

8fbcdc2

update

b725a75

konard requested changes Oct 23, 2021

View reviewed changes

DataService refactoring

6552f9b

little __main__.py refactoring 👀

b676737

add BOTTOM_LANGUAGES, little fix

a662989

konard linked an issue Dec 2, 2021 that may be closed by this pull request

Split data layer to separate class #83

Closed

konard merged commit 9f51b92 into master Dec 2, 2021

Data service #94

Data service #94

Uh oh!

Conversation

dry71 commented Jul 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgtm-com bot commented Jul 17, 2021

Uh oh!

lgtm-com bot commented Jul 17, 2021

Uh oh!

lgtm-com bot commented Jul 17, 2021

Uh oh!

lgtm-com bot commented Jul 17, 2021

Uh oh!

lgtm-com bot commented Jul 17, 2021

Uh oh!

lgtm-com bot commented Jul 18, 2021

Uh oh!

lgtm-com bot commented Aug 6, 2021

Uh oh!

lgtm-com bot commented Aug 6, 2021

Uh oh!

lgtm-com bot commented Aug 7, 2021

Uh oh!

lgtm-com bot commented Aug 8, 2021

Uh oh!

lgtm-com bot commented Aug 8, 2021

Uh oh!

lgtm-com bot commented Aug 8, 2021

Uh oh!

lgtm-com bot commented Aug 21, 2021

Uh oh!

lgtm-com bot commented Sep 11, 2021

Uh oh!

lgtm-com bot commented Sep 11, 2021

Uh oh!

konard Oct 23, 2021

Choose a reason for hiding this comment

Uh oh!

konard Oct 23, 2021

Choose a reason for hiding this comment

Uh oh!

konard Oct 23, 2021

Choose a reason for hiding this comment

Uh oh!

konard Oct 23, 2021

Choose a reason for hiding this comment

Uh oh!

lgtm-com bot commented Dec 1, 2021

Uh oh!

lgtm-com bot commented Dec 1, 2021

Uh oh!

lgtm-com bot commented Dec 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dry71 commented Jul 17, 2021 •

edited

Loading