[lib-chat] Enhance error handling and message formatting#23
Merged
Conversation
Owner
linmx0130
commented
Aug 3, 2025
linmx0130
commented
- Move error types in nah_chat to an independent file.
- Improves error message readability by using "caused by" instead of "source"
- Adds automatic conversion of reqwest errors to nah_chat custom Error type
- Simplifies network error handling code using Rust's try operator (?)
- Updates error formatting to display causes when present
- Extracted `ErrorKind`, `Error`, and `Result` types into a new `error.rs` module - Moved previous error implementation from `lib.rs` to `error.rs` - Added `pub use` statements in `lib.rs` to re-export the error types
1. Improves error message readability by using "caused by" instead of "source" 2. Adds automatic conversion of reqwest errors to nah_chat custom Error type 3. Simplifies network error handling code using Rust's try operator (?) 4. Updates error formatting to display causes when present
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.